Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Create 2 promises `promise1` and `promise2`.

## Instructions
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_promise_basic_DOM/)
- [DEMO LINK](https://zarubina20.github.io/js_promise_basic_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand Down
49 changes: 49 additions & 0 deletions src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,52 @@
'use strict';

// write your code here
const promise1 = new Promise((resolve) => {
document
.querySelector('.logo')
.addEventListener('click', () => resolve(), { once: true });
});

promise1.then(() => {
const div = document.createElement('div');

div.className = 'message';

div.textContent = 'Promise was resolved!';

document.body.appendChild(div);
Comment on lines +10 to +17

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promise1 is missing an error handler (.catch()). Requirement #4 states both promises need success AND error handlers.

});

promise1.catch(() => {
const div = document.createElement('div');

div.className = 'message error-message';

div.textContent = 'Promise was rejected!';

document.body.appendChild(div);
});

const promise2 = new Promise((resolve, reject) => {
setTimeout(() => reject(new Error('Timed out')), 3000);
});

Comment on lines +30 to +33

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promise2 is missing a success handler (.then()). Requirement #4 states both promises need success AND error handlers. The .catch() on line 23 handles errors, but promise2 also needs a .then() for when it resolves (if ever called).

promise2.then(() => {
const div = document.createElement('div');

div.className = 'message';

div.textContent = 'Promise was resolved!';

document.body.appendChild(div);
});

promise2.catch(() => {
const div = document.createElement('div');

div.className = 'message error-message';

div.textContent = 'Promise was rejected!';

document.body.appendChild(div);
});
Loading