add task solution#670
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your getCoinCombination function works correctly, but the test file needs fixing before approval. The test on line 26 has a critical description mismatch — it says '76 cents' but actually tests 67 cents. This inconsistency will confuse students trying to understand what input produces what output. Additionally, the test file is missing three test cases that are explicitly required from the task examples: 6 cents → [1, 1, 0, 0], 17 cents → [2, 1, 1, 0], and 50 cents → [0, 0, 0, 2]. These must be added to meet the requirements checklist. Please fix the test description to match the actual input value and add the missing required test cases.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| expect(getCoinCombination(25)).toEqual([0, 0, 0, 1]); | ||
| }); | ||
|
|
||
| it(`should be 2 'pennies', 1 'nickel', 1 'dime' and 2 'quarters' if there is 76 'cents'`, () => { |
There was a problem hiding this comment.
Test description says '76 cents' but the function is called with 67. This mismatch will confuse students trying to understand what input produces what output.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The test file is complete and correct with all required test cases and accurate expected outputs. The description mismatch has been fixed, and the implementation passes all specified examples without modification.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.