solve#663
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job writing tests that cover all the examples from the task description! Your code is clear and well-structured. I am requesting one small change to make your test suite more complete. The requirements state that the function should handle any 'non-negative integer', which includes 0. Your test suite is currently missing a test for this important edge case. Please add a test case in src/getCoinCombination.test.js to confirm that getCoinCombination(0) returns the expected [0, 0, 0, 0]. This will ensure your tests fully cover the specified input range.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| it(`should be declared`, () => { | ||
| expect(getCoinCombination).toBeInstanceOf(Function); | ||
| it(`if 1 coin should be 1 penny`, () => { |
There was a problem hiding this comment.
You have successfully implemented tests for all the examples in the description. That's great! However, the requirements state that the function should handle any 'non-negative integer'. It's a good practice to test edge cases, so please add a test case for an input of 0 cents.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! I am approving your solution. You've successfully addressed the feedback from the previous review by adding the missing test case for an input of 0. Your test suite is now complete and covers all the requirements from the task description. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.