Solution

[nichelangeloo]

No description provided.

[mateacademy-ai-mentor]

Review Summary

I am requesting changes because the current workflow configuration is very likely to break the required CI behaviour for this task. The job-level defaults.run.working-directory: ./src (in .github/workflows/workflow.yml, near the top of the python-ci job) means that commands like pip install -r requirements.txt and coverage run manage.py test will execute inside src/, but in this exercise manage.py and requirements.txt are expected at the repository root, so these steps will fail instead of running the tests as required [CHECKLIST ITEM #8, #15, #16]. You then compensate for this by doing cd ../ in the flake8 style and complexity steps, which tightly couples those checks to the incorrect ./src working directory and will also be wrong once the working directory is fixed.

To fix this, you should align the working directory with the actual project layout: most likely remove defaults.run.working-directory: ./src entirely so steps run from the repo root where manage.py and requirements.txt live, and then update the flake8 commands to run directly (for example, flake8 . without cd ../). If your project really is under src/, then instead keep working-directory: ./src and update all paths consistently (e.g., pip install -r ../requirements.txt or move requirements.txt into src/, and ensure manage.py is also in src/), and remove the cd ../ workarounds. Once this path/working-directory setup is consistent, your workflow should satisfy all checklist items and allow PR checks to run and pass as intended. Overall the structure and choice of steps are good; resolving this directory mismatch will make your solution complete and reliable.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Using ./src as the default working directory is likely incompatible with this project’s structure (the task’s instructions show running manage.py and pip install -r requirements.txt from the repo root). With this setting, pip install -r requirements.txt and coverage run manage.py test may fail, which would prevent the PR workflow from passing as required by checklist items #8, #15, and #16; consider aligning the working directory with where manage.py and requirements.txt actually live.

[mateacademy-ai-mentor]

This step assumes requirements.txt is in the current working directory, but with working-directory: ./src earlier, it will look for src/requirements.txt. Verify the file location or adjust the working directory so dependency installation works and tests can run, as required by the task.

[mateacademy-ai-mentor]

Running coverage run manage.py test from ./src will fail if manage.py is in the repository root as implied by the task description. Make sure this command is executed from the directory where manage.py actually resides so that the test step can succeed (checklist item #8).

[mateacademy-ai-mentor]

This cd ../ is compensating for the earlier working-directory: ./src. Once you fix the working directory to match the real project layout, you should either remove this directory change or adjust it so flake8 runs from the intended project root without unnecessary path workarounds.

[mateacademy-ai-mentor]

Same as in the style check: this cd ../ tightly couples the step to the ./src working directory. After correcting the working directory, ensure flake8 runs from the correct location without relying on moving up a directory.

[mateacademy-ai-mentor]

Review Summary

I am requesting changes because there is still a critical mismatch between the workflow’s working directory and the expected project layout that will likely break dependency installation. At the job level in .github/workflows/workflow.yml, defaults.run.working-directory: ./src makes every step run from src/, but your pip install -r requirements.txt step still assumes requirements.txt is in the current directory, while the exercise expects it at the repo root; this will cause pip to fail to find the file, so tests and coverage will not actually run. This directly conflicts with the earlier high-priority requirement to either remove the ./src working directory or consistently adjust all paths to match the real file locations.

To fix this, choose one strategy and apply it consistently: either (1) remove defaults.run.working-directory: ./src, run everything from the repo root, and change your commands to something like coverage run src/manage.py test and flake8 .; or (2) keep working-directory: ./src but change the install step to point to the real requirements location (for example, pip install -r ../requirements.txt if the file is at the root) and ensure any artifact and flake8 paths correctly cover the intended code. Once this directory/path alignment is corrected so that dependencies install and tests/coverage run successfully, the workflow will meet the functional requirements. Aside from this blocker, the rest of your workflow setup (triggers, run name, coverage, flake8 with continue-on-error, artifact upload, and Python version via env variable) looks solid and close to what’s needed. This is a good effort so far—resolving the working directory issue will complete the CI configuration cleanly.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

The job-level defaults.run.working-directory: ./src forces every step to run inside src/, but your commands still assume requirements.txt is in the current directory; in the provided exercise layout, requirements.txt is expected at the repo root, so this will cause pip install -r requirements.txt (and potentially other steps) to fail—either remove this default and run from the root, or adjust all paths (e.g. pip install -r ../requirements.txt) so they match the actual file locations, as required by the previous high-priority correction.

[mateacademy-ai-mentor]

Because the working directory is ./src, this pip install -r requirements.txt will look for requirements.txt inside src/, which does not match the exercise’s expectation that you install from the root; you need to either run this step from the repo root or change the path (for example, ../requirements.txt) so dependencies are actually installed before tests run.

[mateacademy-ai-mentor]

With working-directory: ./src applied at the job level, this coverage run manage.py test will execute inside src/, which is fine for manage.py but coupled to the same directory assumption that breaks your dependency installation; once you fix the working directory strategy (root vs src/), make sure this command and the install step are consistent—for example, if you drop the ./src default, you’d run coverage run src/manage.py test from the repo root instead.

[mateacademy-ai-mentor]

Review Summary

I am approving your solution as part of an educational override so you can continue progressing while you learn and refine your CI setup. You’ve done a solid job configuring the workflow triggers, setting the run name with both the actor and commit hash, installing dependencies from the repo root, running tests under coverage, adding flake8 style and complexity checks with continue-on-error, and uploading artifacts. The main issue to address is in .github/workflows/workflow.yml: your Run tests step currently calls coverage run manage.py test from the repo root, but your manage.py file lives at src/manage.py, so this command would fail in a real project because manage.py is not found at the root. To fix this, either move manage.py to the repo root to match the command, or update the command to coverage run src/manage.py test so coverage and tests run successfully. As a minor improvement, consider using a Python version in PYTHON_VERSION that is known to be available on GitHub-hosted runners (for example, 3.10 or 3.11) to avoid setup failures. Overall, your structure and intent are correct, and with a small path adjustment you’ll have a fully functional CI pipeline—nice work getting this close to a production-ready workflow.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Footnotes

1. Rate AI review example ↩

[mateacademy-ai-mentor]

Your workflow runs coverage run manage.py test from the repo root, but the manage.py file you’ve added lives under src/manage.py. In a project that actually uses src/manage.py, this command will fail because manage.py isn’t found at the root. Align either the file location (move manage.py to the root) or the command (e.g. point to src/manage.py) so tests and coverage can run successfully as required.