add solution

[taniakolesnik]

No description provided.

[taniakolesnik]

test

[mateacademy-ai-mentor]

Review Summary

This is a great start, and your workflow is well-structured, meeting most of the requirements. However, changes are needed because a configuration issue will cause the workflow to fail. In your .github/workflows/workflows.yml file, you've set a default working-directory of ./src/ for all run steps. This will cause the 'Install dependencies' step to fail because the pip install -r requirements.txt command will be executed from within the ./src/ directory, where the requirements.txt file doesn't exist. To fix this, please remove the global defaults block and instead add the working-directory: ./src/ property only to the specific steps that require it, such as your testing and linting steps.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Setting a default working-directory for all run steps at the job level will likely cause the 'Install dependencies' step to fail. The pip install -r requirements.txt command will be executed from within the ./src/ directory, but the requirements.txt file is typically in the project root. Consider removing this defaults block and adding the working-directory: ./src/ property to only the steps that need it (e.g., tests, coverage, linting).

[mateacademy-ai-mentor]

Review Summary

Great job on this workflow! I'm happy to approve your submission as it meets all the requirements. You've also done well to address the previous feedback on the working-directory configuration.

As a small suggestion for improvement, you can make the workflow more efficient by removing the Run tests step in .github/workflows/workflows.yml. The next step, Coverage report, already runs the tests with pytest --cov, so the first test run is redundant.

This is just a minor optimization, and overall, this is excellent work!

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Footnotes

1. Rate AI review example ↩

[mateacademy-ai-mentor]

This step is redundant because the next step, Coverage report, also runs the tests with pytest. Running the tests twice is inefficient. You can safely remove this Run tests step and let the coverage step handle both testing and reporting.