create workflow for todolist#81
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the GitHub Actions workflow! The overall structure is correct and you've included all the necessary steps. However, this requires a change because a small configuration issue is preventing the workflow from running successfully.
In .github/workflows/workflow.yaml, the working-directory: ./src is applied globally to all run steps. This causes the pip install -r requirements.txt command to fail because the requirements.txt file is in the project root, not the src directory.
To fix this, please remove the global defaults block and apply the working-directory: ./src property individually to the specific steps that need it (like testing, coverage, and linting). After that change, everything should work as expected!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job addressing the previous feedback by removing the global working-directory! The workflow is much closer to working correctly, but this requires a few changes as some critical path issues are causing the CI job to fail. First, the path to requirements.txt in the 'Install dependencies' step is incorrect; since run steps execute from the repository root, the command should be pip install -r requirements.txt. Additionally, the test and coverage steps need to be executed from within the source directory, so please add working-directory: ./src to the Run unit tests, Generate coverage, and Display the coverage report to console steps. Once these paths are corrected, the workflow should run successfully.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r ../requirements.txt |
There was a problem hiding this comment.
This path to requirements.txt is incorrect. By default, run steps in a workflow execute from the root directory of your repository. Since requirements.txt is located in the root, the correct command is pip install -r requirements.txt.
linubah
left a comment
linubah
left a comment
There was a problem hiding this comment.
last step required
PR workflow should be triggered and should pass all the checks.
linubah
left a comment
linubah
left a comment
There was a problem hiding this comment.
last step required
PR workflow should be triggered and should pass all the checks.
3 participants
No description provided.