CI for Python App#79
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This requires a couple of changes before it can be approved. The workflow is well-structured, but there's a critical issue in the Generate coverage step that will cause the build to fail. The command coverage run manage.py pytest is incorrect because manage.py does not have a pytest subcommand. To fix this, please change the command to coverage run -m pytest.
Additionally, the tests are currently being run twice, which is inefficient. You can remove the Run tests step entirely and rely on the corrected coverage step to both run the tests and collect the data in a single action. Great job on the overall structure!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! You've successfully addressed all the feedback from the previous review. The workflow is now clean, efficient, and correctly implements all requirements, including the triggers, job steps, and variable usage. I'm approving this submission.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
linubah
left a comment
linubah
left a comment
There was a problem hiding this comment.
Good job! But missing last requirement: PR workflow should be triggered and should pass all the checks
|
@linubah please check again, thanks |
4 participants
No description provided.