Add GitHub Actions Python CI workflow#78
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on setting up this GitHub Actions workflow! It's well-structured and meets most of the requirements. However, one change is needed before this can be approved.
The workflow currently uploads the Python runtime version as an artifact, but the requirement is to upload the project's source code. Please modify the upload-artifact step to archive the directory containing your application's code. You can remove the preceding step that saves the Python version to a file, as it won't be needed.
Once that's fixed, this will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed all the requirements, and the workflow is well-structured. I am approving your submission. I have one small suggestion to make the workflow more efficient. The 'Run tests' step in .github/workflows/python-ci.yml is redundant because the 'Generate coverage' step also runs the tests via coverage run manage.py test. You can safely remove the first test step to speed up the workflow. This is a minor optimization, and the current implementation is perfectly fine.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| - name: Run tests | ||
| working-directory: src | ||
| run: | | ||
| python manage.py test |
There was a problem hiding this comment.
This step is redundant because the 'Generate coverage' step on line 40 also runs the tests. To make the workflow more efficient, you can remove this step. The coverage run manage.py test command fulfills both the requirement to run tests and to generate coverage data.
2 participants
No description provided.