Task 16: add NSGs and attach to subnets#42
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on creating the Network Security Groups and attaching them to the correct subnets. However, this requires a change because the security rules for the webservers and management subnets are too permissive.
The requirements specify that these subnets should only accept traffic 'from the Internet'. Your current implementation uses * as the SourceAddressPrefix, which allows traffic from any source. To fix this, you should use the Internet service tag, which correctly restricts access to sources outside of Azure.
For example, in your New-AzNetworkSecurityRuleConfig cmdlets, please change -SourceAddressPrefix "*" to -SourceAddressPrefix "Internet".
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I am approving your submission. You've successfully incorporated the previous feedback, and the script now meets all project requirements. The security rules are correctly configured using the Internet service tag, and the overall implementation is clean and effective. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.