solution#39
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on setting up the Network Security Groups and defining the correct rules for each subnet! The main issue preventing approval is that the NSGs are not associated with their respective subnets in task.ps1. This means the security rules, while correctly defined, are not actually being applied to the network traffic, which is a core requirement of the task. To resolve this, please update the New-AzVirtualNetworkSubnetConfig cmdlet for each subnet to include the corresponding NSG. You can do this by passing the NSG object to the -NetworkSecurityGroup parameter.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| $webSubnet = New-AzVirtualNetworkSubnetConfig -Name $webSubnetName -AddressPrefix $webSubnetIpRange | ||
| $dbSubnet = New-AzVirtualNetworkSubnetConfig -Name $dbSubnetName -AddressPrefix $dbSubnetIpRange | ||
| $mngSubnet = New-AzVirtualNetworkSubnetConfig -Name $mngSubnetName -AddressPrefix $mngSubnetIpRange |
There was a problem hiding this comment.
These subnet configurations are created without being associated with the Network Security Groups defined earlier in the script. The task requires that each NSG is attached to its corresponding subnet. You can achieve this by using the -NetworkSecurityGroup parameter in the New-AzVirtualNetworkSubnetConfig cmdlet for each subnet.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am approving your solution as you've successfully addressed the previous feedback by correctly associating the Network Security Groups with their corresponding subnets. The PowerShell script now correctly configures all the required security rules and applies them to the virtual network, meeting all task requirements. Great job resolving the issue and completing the task!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.