solution#38
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on the Network Security Groups and their rules; the traffic flow logic is correctly implemented. However, I am requesting a change because the script targets the wrong resource group. The task requires all resources to be created in the mate-resources group, but your script uses a different one, which will cause the validation to fail. Please update the $resourceGroupName variable in task.ps1 to "mate-resources" to fix this.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! You've successfully addressed the previous feedback by correcting the resource group name. The PowerShell script now perfectly meets all requirements: it correctly creates the three Network Security Groups, defines the appropriate rules for each, and associates them with their respective subnets. The traffic flow logic is implemented exactly as specified. I am happy to approve your solution, well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.