Skip to content

Solution#30

Open
maximprysyazhnikov wants to merge 2 commits into
mate-academy:mainfrom
maximprysyazhnikov:develop
Open

Solution#30
maximprysyazhnikov wants to merge 2 commits into
mate-academy:mainfrom
maximprysyazhnikov:develop

Conversation

@maximprysyazhnikov

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: APPROVE

Your submission fully meets the task requirements. The task.ps1 script correctly creates NSGs named webservers, database, and management, applies the exact inbound rules required (VNet allow on priority 100; HTTP/HTTPS for webservers; SSH for management; no Internet ingress for database), ensures unique priorities, and associates each NSG to the correct subnet. It’s idempotent, non-interactive, and uses Az cmdlets properly. The artifact workflow is solid: scripts/generate-artifacts.ps1 exports the template, uploads it with a SAS URL, and updates artifacts.json, which is valid and complete.

Minor (non-blocking) suggestions:

  • Consider adding a brief inline comment near rule priorities to document the rationale.
  • Optionally print a concise summary at the end of task.ps1 confirming NSG names, rules, and subnet associations.

Great work—this should pass validation as-is.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants