Solution#28
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
There is a critical issue in your task.ps1 script: the variable $ruleDb is used before it is defined, which will cause the script to fail or misconfigure the database NSG. Additionally, the required result.json file is missing from your submission. Please define $ruleDb properly, ensure all required files are committed, and then resubmit. You're almost there—just a couple of fixes needed! 😊
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| $dbNsg = New-AzNetworkSecurityGroup -Name "nsg-database" ` | ||
| -ResourceGroupName $resourceGroupName -Location $location ` | ||
| -SecurityRules $ruleDb |
There was a problem hiding this comment.
Error: The variable $ruleDb is used here but is not defined anywhere in the script. You need to create a security rule for the database subnet (e.g., allowing only necessary ports such as 1433 for SQL or as required by your database) and assign it to $ruleDb before using it in the New-AzNetworkSecurityGroup command.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your script logic is correct and meets all the task requirements for NSGs and subnet rules—great job! 🎉 However, your submission is missing the required result.json file, which is essential for validating your deployment. Please generate and commit result.json as instructed, and you'll be all set!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| $dbNsg = New-AzNetworkSecurityGroup -Name "nsg-database" ` | ||
| -ResourceGroupName $resourceGroupName -Location $location ` | ||
|
|
There was a problem hiding this comment.
Issue: The database NSG (nsg-database) is created without any security rules. According to typical requirements, you should define and assign the necessary security rules for the database subnet. Please check the task checklist and add the required rules to $dbNsg.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work! Your implementation of the NSG and subnet configuration in task.ps1 fully meets the technical requirements, with correct rules and associations as specified by the task. However, your submission is missing the required result.json file, which is essential for validating your deployment and is explicitly required by the instructions. Please make sure to run the artifact generation and validation scripts (scripts/generate-artifacts.ps1 and scripts/validate-artifacts.ps1) and commit the resulting result.json file. This is a critical step for future submissions—without it, your work cannot be fully validated or accepted, even if the infrastructure code is correct.
No other issues were found, and your code is otherwise well-structured and compliant with all constraints. Keep up the good work! 🚀 Please address the missing artifact in your next submission to ensure a smooth review process. If you need more guidance, check the task instructions or reach out for help. You're making great progress—keep learning and improving!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.