Skip to content

Solution#26

Open
Volodymyrdv wants to merge 1 commit into
mate-academy:mainfrom
Volodymyrdv:develop
Open

Solution#26
Volodymyrdv wants to merge 1 commit into
mate-academy:mainfrom
Volodymyrdv:develop

Conversation

@Volodymyrdv

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job! 🎉 Your implementation meets all the core requirements: each subnet has its own NSG, the correct rules are applied, and the database subnet does not allow any Internet traffic, which matches the task's requirements. The concern about the database NSG having no explicit rules is not an issue here, since the default NSG behavior is to deny inbound traffic from the Internet. If future requirements specify more granular rules for the database subnet, you can update the NSG accordingly. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread task.ps1
Comment on lines +55 to 59
$nsgDb = New-AzNetworkSecurityGroup `
-Name $dbSubnetName `
-ResourceGroupName $resourceGroupName `
-Location $location `

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: The database subnet NSG (nsgDb) is created without any security rules. If the task or checklist requires specific rules for the database subnet (e.g., only allow traffic from the web subnet or management subnet), you should add them here. As it stands, the NSG will have no custom rules, which may not be secure or compliant with the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants