Develop#715
Open
AngelaStrechen wants to merge 5 commits into
Open
Conversation
added 2 commits
May 21, 2026 12:36
brespect
suggested changes
May 21, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, check next:
- There should be no scroll on mobile view:
-
Add hover to all interactive elements > links, logos, images.
-
This button should scrolls up to the top of page:
- Can't open the header using burger menu:
- The should be radio buttons under the slider on mobile:
6., Add the favicon.
brespect
suggested changes
May 21, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Not all poinst from previous review were fixed, please request review only when you will be ready with this
brespect
suggested changes
May 21, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Still not, make sure you have deployed your solution
Author
|
Та ніби вже все працює,
переходжу по DEMO і все добре у мене
чт, 21 трав. 2026 р. о 13:44 Bohdan Lesyk ***@***.***> пише:
… ***@***.**** requested changes on this pull request.
Not all poinst from previous review were fixed, please request review only
when you will be ready with this
—
Reply to this email directly, view it on GitHub
<#715 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXNA6XUH6XFYRMVIWTBYVIL433T27AVCNFSM6AAAAACZHO5B7CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGMZWGU4DAMBSHE>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
2pasha
suggested changes
May 22, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- make navigation scroll smoothly
- it's better to disable scrolling when menu is opened
- add some content container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK