Eco Cosmetic#393
Conversation
| <main class="main"> | ||
| <section class="aboutOurBrand"> | ||
| <p class="main__paragraph">if you choose the gifts of nature and care about it’s - scroll down</p> |
There was a problem hiding this comment.
fix BEM class naming Using an Element Inside Another Block
There was a problem hiding this comment.
I forgot to remove it from section About our Brand. It should be good know. later im going to add separate section for this paragraph, cause in readme.md stands so (Implement If you choose the gifts of nature and care about it’s - scroll down block.)
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
remember to always update your deployment before requesting a review ;)
|
sorry, It should be ok now. |
| </section> | ||
|
|
||
| <section class="shop" id="shop"> | ||
| <h2 class="title title--secondary">shop</h2> |
There was a problem hiding this comment.
this title should be centered
| class="shop__image"> | ||
|
|
||
| <p class="shop__product-name">hydrophilic oil</p> | ||
| <p class="shop__product-value">160 UAH</p> |
There was a problem hiding this comment.
there should be 10px space between product name and value
|
thanks for review ;) |
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- Buttons “shop”, “to contact us”, “all products” must be with hover styles
- All items in the shop section must have hover effects
- All interactive elements(links, buttons, pictures, icons) should have a hover effect and cursor pointer. User must intuitively understand that he can interact with some element
- The user must have the opportunity to conveniently write 2-3 lines of text in the message input field
- The form shouldn’t submit empty
| <li class="list-sec__list"></li><a href="#contact-us"class="list-sec__link">contact</a></li> | ||
| <li class="list-sec__list"></li><a href="#about"class="list-sec__link">About</a></li> |
There was a problem hiding this comment.
you close li tag two times
| <li class="list-sec__list"></li><a href="#contact-us"class="list-sec__link">contact</a></li> | |
| <li class="list-sec__list"></li><a href="#about"class="list-sec__link">About</a></li> | |
| <li class="list-sec__list"><a href="#contact-us"class="list-sec__link">contact</a></li> | |
| <li class="list-sec__list"><a href="#about"class="list-sec__link">About</a></li> |
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- zdjęcie nie jest odpowiednio wycentrowane
- nawigacja sekcji shop nie jest wycentrowana
- pierwszy element nawigacji jest zawsze zaznaczony
|
Cześć, naprawiłem te błędy, nie wiem tylko o co chodzi z tym wcisnietym pierwszym elementem, u mnie tego nie ma, nawigacja normalnie sie przelacza. |
|
|
zibi-dev
left a comment
zibi-dev
left a comment
There was a problem hiding this comment.
U mnie jak u Natali problem wystepuje.
|
W ostatnim inpucie w formie, stylowanie tekstu odstaje od pozostalych pol |
|
Teraz powinno być dobrze ;) |
danon321
left a comment
danon321
left a comment
There was a problem hiding this comment.
Ok mobilny widok wyglada juz na prawde dobrze! :D gratuluje! Teraz czas aby twoja strona również była tak samo piekna na wiekszych ekranach
4 participants
https://MarcinMaka37.github.io/Eco_cosmetics/