Add task solution#390
Conversation
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
Great work :D fix BEM mistakes that I mark in comments and you can try to make sliders using e.g. input radio and transform translate (like here). Also you forgot about underline for all learn more elements
|
|
||
| <a | ||
| href="#shop" | ||
| class="button--type1 header__button--type1" |
There was a problem hiding this comment.
button--type1 it's modifier but it's used like block
(https://mate-academy.github.io/fe-program/css/typical-bem-mistakes-en#using-a-modifier-without-the-belonging-class)
| class="button--type1 header__button--type1" | |
| class="button button-type1 header__button-type1" |
or
| class="button--type1 header__button--type1" | |
| class="button button--type1 header__button" |
or
| class="button--type1 header__button--type1" | |
| class=""header__button header__button--type1" |
| <textarea | ||
| placeholder="Your Message" | ||
| id="message" | ||
| class="form__textarea form__input" |
There was a problem hiding this comment.
why it has two element classes? change one of them into modifier instead
|
|
||
| <a | ||
| href="#address" | ||
| class="button--type2 section__button--type2" |
There was a problem hiding this comment.
|
|
||
| <a | ||
| href="#address" | ||
| class="button--type2 section__button--type2" |
There was a problem hiding this comment.
|
|
||
| <a | ||
| href="#contact-us" | ||
| class="section__button--type1 button--type1 section__contact-button" |
There was a problem hiding this comment.
|
|
||
| <a | ||
| href="#address" | ||
| class="button--type2 section__button--type2" |
There was a problem hiding this comment.
|
DEMO LINK |
|
Important!!! |
| @use '../utils/mixins' as *; | ||
|
|
||
| .button { | ||
| &--type1 { |
There was a problem hiding this comment.
Tutaj jedynie moze mogłabys uzyć lepszego nazwenictwa. Type1 mało mówi.
Patrz jak to rozwiązali np w bibliotece komponentów MUI
<Button variant="text">Text</Button> <Button variant="contained">Contained</Button> <Button variant="outlined">Outlined</Button>
https://mui.com/material-ui/react-button/
|
DEMO LINK |
3 participants
DEMO LINK
Please check my mobile version and give some advices. Please also check my BEM. I don't know how to make sliders, so my shop section without slider.