Eco cosmetic was created#380
Open
Serhii-Khobotov wants to merge 6 commits into
Open
Conversation
Author
|
https:// |
vadiimvooo
suggested changes
Apr 4, 2024
vadiimvooo
left a comment
vadiimvooo
left a comment
There was a problem hiding this comment.
Well done. Just a few fixes:
- Please add transition on hover effect for this element
- Add this link to the description of your PR, also please use link markup provided by github.
Author
|
Sorry, i forget how to do that |
Author
IvanFesenko
suggested changes
Apr 5, 2024
IvanFesenko
left a comment
IvanFesenko
left a comment
There was a problem hiding this comment.
Good job, Check this issues:
- favIcon is epsent
- Logo didn't match design
- if you add validation user shoud know what format should be
- On hover line should be same width as text
volodymyr-soltys97
suggested changes
Apr 5, 2024
volodymyr-soltys97
left a comment
volodymyr-soltys97
left a comment
There was a problem hiding this comment.
Good job 👍
Let's improve your page
- Add a favicon on the page
- Add cursor pointer for all clickable elements
Comment on lines
+60
to
+61
| [DEMO LINK](https:// | ||
| Serhii-Khobotov.github.io/Eco_cosmetics/). |
There was a problem hiding this comment.
Fix this link and update it in the PR description
Suggested change
| [DEMO LINK](https:// | |
| Serhii-Khobotov.github.io/Eco_cosmetics/). | |
| [DEMO LINK](https://Serhii-Khobotov.github.io/Eco_cosmetics/). |
Author
Author
|
|
vadiimvooo
suggested changes
Apr 5, 2024
vadiimvooo
left a comment
vadiimvooo
left a comment
There was a problem hiding this comment.
You have to push your favicons. Also you didn't add cursor pointer as was mentioned before. Please feel free to ask for help in fe_chat if you need so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://
Serhii-Khobotov.github.io/Eco_cosmetics/