add task solution#379
Open
bohdanbilozor wants to merge 7 commits into
Open
Conversation
|
IvanFesenko
suggested changes
Mar 29, 2024
IvanFesenko
left a comment
There was a problem hiding this comment.
- Not fixed, also form not cleared on submit

- Design miss match


- Check this case
https://github.com/mate-academy/Eco_cosmetics/assets/61904995/2689fe91-99aa-44e9-a371-9db07925eb58
anastasiiavorobiova
suggested changes
Apr 2, 2024
Viktor-Kost
suggested changes
Apr 2, 2024
Viktor-Kost
left a comment
There was a problem hiding this comment.
Nice!)
To improve:
- check form styles
- add hover effects to your links
Recommendations:
- change a year to a current one
- check markup
- Suggest making sure that on desktops, the content section doesn't spread across the entire screen. Instead, it should have a maximum width. If there's a background image, image shouldn't be limited (only a section content). To do this, you need to apply the right styles in your CSS.
Why it's important:
Fits well: Setting a maximum width ensures that your design looks good on desktops without the content becoming too wide.
Easy to read: Keeping the content width in check makes it easier for people to read, as really long lines of text can be hard to understand.
Same look: Having a maximum content width helps maintain a consistent design, especially when using background images that go beyond the content area.
Easy to organize: Limiting the content width makes it simpler to organize your content on the page. This makes it easier for developers and designers to manage.
anastasiiavorobiova
suggested changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.














https://bohdanbilozor.github.io/Eco_cosmetics/