update: save kgird data to context#151
Open
VsevolodX wants to merge 3 commits into
Open
Conversation
VsevolodX
commented
Jun 13, 2026
| /** Re-run `setData` normalization before persisting (e.g. derive grid metric from dimensions). */ | ||
| syncPersistentData() { | ||
| this.setData(this.getData()); | ||
| } |
Member
Author
There was a problem hiding this comment.
Right now for example if we use (2 2 2) kgrid on Si2, then the gridMetricValue is still shown "5" by default in UI -- which is not true, the "16" value is used in calculations.
Not isEdited=True -- thus it is not updated, while it would be if it was edited.
VsevolodX
commented
Jun 13, 2026
|
|
||
| /** Context items always serialized on the unit so rupy can store them in scope after execution. */ | ||
| const CONTEXT_SCOPE_ITEMS = new Set(["kgrid"]); | ||
|
|
Member
Author
There was a problem hiding this comment.
No premature optimization. Either storing full contexts on each unit -- which will be too much, or specifying those that are actually needed during the job running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.