Skip to content

update: use utils, remove code #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VsevolodX wants to merge 3 commits into from
Closed

update: use utils, remove code #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37be34c
update: use utils, remove code
VsevolodX May 28, 2026
d1056df
chore: code
VsevolodX May 28, 2026
67f1755
chore: utils
VsevolodX May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions dist/mixins/bonds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { math } from "@mat3ra/code/dist/js/math";
import { filterBondsDataByElementsAndOrder, getElementsBondsData } from "@mat3ra/periodic-table";
import { Utils } from "@mat3ra/utils";
import createKDTree from "static-kdtree";
import * as THREE from "three";
/*
Expand Down Expand Up @@ -37,7 +37,7 @@ export const BondsMixin = (superclass) => class extends superclass {
*/
// TODO: move to made basis bonded
areElementsBonded(element1, coordinate1, element2, coordinate2, bondsData) {
const distance = math.vDist(coordinate1, coordinate2);
const distance = Number(Utils.math.default.vDist(coordinate1, coordinate2));
const connectivityFactor = this.settings.chemicalConnectivityFactor;
return Boolean(filterBondsDataByElementsAndOrder(bondsData, element1, element2).find((b) => {
return (b.length.value &&
Expand Down Expand Up @@ -70,9 +70,11 @@ export const BondsMixin = (superclass) => class extends superclass {
*/
// TODO: move to made basis bonded
getMaxBondLength(bondsData) {
var _a;
const connectivityFactor = this.settings.chemicalConnectivityFactor;
return (connectivityFactor *
math.max(bondsData.map((b) => b.length.value || 0)));
const bondLengths = bondsData.map((b) => b.length.value || 0);
const maxLen = Number((_a = Utils.math.default.max(bondLengths)) !== null && _a !== void 0 ? _a : 0);
return connectivityFactor * maxLen;
}
/**
* Returns an array of [element, coordinate] for all elements and their neighbors.
Expand Down
Loading
Loading