feature/SOF-7916 Feat: add Formation Energy contributions#407
Merged
Conversation
VsevolodX
commented
Jun 10, 2026
VsevolodX
commented
Member
- feat: add formation energy contributions
- chore: regen
| "values": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", |
Member
There was a problem hiding this comment.
Should be separate - formation_energy_contribution - singular
| }, | ||
| "precision_metric": { | ||
| "description": "metric used to report total energy precision", | ||
| "type": "string" |
Member
There was a problem hiding this comment.
We have to define enums for precision_metric and value if we require it
Member
There was a problem hiding this comment.
Let's leave space for precision_metric = "unknown" and the corresponding value of -1
Member
There was a problem hiding this comment.
We can have those as default
timurbazhirov
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.