Skip to content

update: fix cluster#331

Merged
VsevolodX merged 3 commits into
mainfrom
fix/cluster
Jun 15, 2026
Merged

update: fix cluster#331
VsevolodX merged 3 commits into
mainfrom
fix/cluster

Conversation

@VsevolodX

@VsevolodX VsevolodX commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Fixed cluster configuration lookup in workflow examples to correctly identify cluster resources.
    • Corrected workflow template rendering for Quantum Espresso calculations to properly configure templates.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@VsevolodX, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 23 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc8a8214-ed1b-4672-b0bc-0076890a1e7a

📥 Commits

Reviewing files that changed from the base of the PR and between 21e7b7a and caf2e66.

📒 Files selected for processing (2)
  • config.yml
  • examples/workflow/qe_scf_calculation.ipynb
📝 Walkthrough

Walkthrough

Two targeted fixes in examples/workflow/qe_scf_calculation.ipynb: the cluster name lookup switches from cluster_config["displayName"] to cluster_config["hostName"], and workflow template population now sets only the content field with the generated bash script, removing the previous assignment to the rendered field.

Changes

QE SCF Calculation Notebook Fixes

Layer / File(s) Summary
Cluster hostName lookup and template content-only assignment
examples/workflow/qe_scf_calculation.ipynb
CLUSTER_NAME now reads from cluster_config["hostName"] instead of cluster_config["displayName"]. Workflow template population sets only content to the generated QE bash script; the rendered field assignment is removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Exabyte-io/api-examples#328: Directly modifies the same notebook's workflow template content/rendered field assignments for the QE bash script.
  • Exabyte-io/api-examples#305: Modifies qe_scf_calculation.ipynb template-rendering logic for injecting the QE script into workflow body fields.
  • Exabyte-io/api-examples#276: Overlaps at the cluster-selection/config wiring level, refactoring how CLUSTER_NAME and queue settings are derived from cluster config.

Suggested reviewers

  • timurbazhirov

Poem

🐇 Hop hop, the hostname was wrong,
displayName sang the old song.
Now hostName leads the way,
rendered fields? Gone today!
The template content stands alone —
A cleaner workflow, carved in stone. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update: fix cluster' is vague and generic, using non-descriptive terms that don't clearly convey the specific changes made to the pull request. Consider using a more specific title that describes the actual changes, such as 'Fix cluster configuration lookup in QE SCF calculation notebook' or 'Update cluster name field mapping in workflow example'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cluster

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VsevolodX VsevolodX merged commit a3a4ec2 into main Jun 15, 2026
8 checks passed
@VsevolodX VsevolodX deleted the fix/cluster branch June 15, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants