Skip to content

DP-47635 - Resolve warning icon color contrast issue#2079

Merged
clairesunstudio merged 4 commits into
developfrom
patternlab/DP-47635-fix-message-box-color-contrast
Jun 17, 2026
Merged

DP-47635 - Resolve warning icon color contrast issue#2079
clairesunstudio merged 4 commits into
developfrom
patternlab/DP-47635-fix-message-box-color-contrast

Conversation

@karthikbaikati

Copy link
Copy Markdown
Collaborator

Description

This PR addresses an accessibility color contrast issue in the warning inline message box component. The warning icon's previous yellow color (#f6c51b) had a contrast ratio under 1.5:1 against the light-yellow background (#fef9e8).

By switching to the standard design system token var(--mds-background-section-utility-warning-highest, #7b5705), the contrast ratio is increased to ~7.07:1, successfully satisfying the WCAG 2.1 AA requirement of at least 3:1 for user interface and graphical components.

Related Issue / Ticket

Steps to Test

  1. Compile and build the workspace.
  2. Start the local dev server.
  3. Open the warning inline message pattern page: http://localhost:3000/patterns/02-molecules-inline-message-warning/02-molecules-inline-message-warning.html
  4. Inspect the SVG warning icon and verify its color resolves to --mds-background-section-utility-warning-highest (#7b5705).
  5. Verify that the contrast ratio is at least 3:1 (it is ~7.07:1).

Screenshots

Screenshot 2026-06-16 at 2 14 59 PM

Additional Notes:

Impacted Areas in Application

  • packages/assets/scss/02-molecules/_inline-message.scss (Warning Inline Message Box component)

@karthikbaikati karthikbaikati self-assigned this Jun 16, 2026
Copilot AI review requested due to automatic review settings June 16, 2026 18:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an accessibility color-contrast issue for the warning inline message icon by switching the SVG icon color to a darker, higher-contrast design token.

Changes:

  • Update warning inline message icon color/fill to use --mds-background-section-utility-warning-highest (fallback #7b5705) to meet WCAG contrast requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/assets/scss/02-molecules/_inline-message.scss Outdated
Comment thread packages/assets/scss/02-molecules/_inline-message.scss Outdated
Comment thread packages/assets/scss/02-molecules/_inline-message.scss Outdated
Comment thread packages/assets/scss/02-molecules/_inline-message.scss Outdated
@karthikbaikati karthikbaikati force-pushed the patternlab/DP-47635-fix-message-box-color-contrast branch from de409c0 to d7918a6 Compare June 16, 2026 19:27
@clairesunstudio

Copy link
Copy Markdown
Contributor

Test failures are map visual regression test diffs, not related to this PR

Comment thread packages/assets/scss/02-molecules/_inline-message.scss Outdated
@clairesunstudio clairesunstudio merged commit 2997170 into develop Jun 17, 2026
15 of 16 checks passed
@clairesunstudio clairesunstudio deleted the patternlab/DP-47635-fix-message-box-color-contrast branch June 17, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants