Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/masoniteorm/relationships/BelongsToMany.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ def relate(self, related_record):

return result

def map_related(self, related_result):
return related_result

def register_related(self, key, model, collection):
model.add_relation(
{
Expand Down
14 changes: 14 additions & 0 deletions tests/sqlite/relationships/test_sqlite_relationships.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,17 @@ def test_belongs_to_eager_many(self):
store = Store.hydrate({"id": 2, "name": "Walmart"})
store = Store.with_("products").first()
self.assertEqual(store.products.count(), 3)

def test_belongs_to_eager_many_on_collection(self):
# Eager loading a BelongsToMany onto a collection (get) used to raise
# NotImplementedError because map_related was not implemented. See #12.
stores = Store.with_("products").get()
self.assertEqual(stores.count(), 2)

products_by_store = {
store.id: sorted(product.id for product in store.products)
for store in stores
}
# Each store keeps its own related products rather than sharing one set.
self.assertEqual(products_by_store[1], [1, 2, 3])
self.assertEqual(products_by_store[2], [4, 5, 6])