fix: properly merge PR #415 tap & hold feature#419
Merged
Conversation
PR #415 was marked as merged but commits never made it to develop branch. Cherry-picked the three feature commits to restore functionality: - Add enterSelectModeWithSelection to useBookListView - Integrate useLongPress hook in BookListItem - Wire up long-press handlers in DraggableBookList and shelves page - Add keyboard accessibility (Space/Enter keys) - Add comprehensive test coverage (22 tests) Note: hooks/useLongPress.ts already existed on develop from commit 9f2ca50 and matches the final PR version, so it was kept unchanged. Original commits: - b88e3fc feat: implement tap & hold to select shelf items - 990c8aa fix: implement @review feedback (iteration 1) - f623bb4 fix: add onTouchCancel handler and Enter key accessibility support Resolves #414 Fixes #415 Co-authored-by: OpenCode <assistant@opencode.ai>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #419 +/- ##
===========================================
+ Coverage 78.70% 78.82% +0.12%
===========================================
Files 167 168 +1
Lines 7559 7607 +48
Branches 1850 1860 +10
===========================================
+ Hits 5949 5996 +47
Misses 1127 1127
- Partials 483 484 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Owner
Author
|
@copilot /review |
Contributor
Ran review checks on commit UI screenshot: N/A (no UI changes made in this review pass). |
Copilot stopped work on behalf of
masonfox due to an error
April 16, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PR #415 which was marked as MERGED in GitHub but the commits never actually made it into the develop branch. This PR cherry-picks the three orphaned feature commits to restore the tap & hold to select functionality.
Problem: PR #415 shows as merged, but the feature code is missing from develop (except for
useLongPress.tswhich was added separately in commit 9f2ca50).Solution: Cherry-picked the three orphaned commits and squashed them into a single commit with proper attribution.
Changes
Modified Files (5)
hooks/useBookListView.ts- AddedenterSelectModeWithSelection()functioncomponents/Books/BookListItem.tsx- Integrated useLongPress hook + keyboard accessibilitycomponents/Books/DraggableBookList.tsx- Added long-press props and wiringapp/shelves/[id]/page.tsx- Wired up long-press handlers to list viewsNew Files (1)
__tests__/hooks/useLongPress.test.ts- Comprehensive test suite (22 tests)Note:
hooks/useLongPress.tsalready existed on develop (added by commit 9f2ca50) and matches the final PR version, so it was kept unchanged.Feature: Tap & Hold to Select
Implements long-press gesture to enter select mode on shelf items, eliminating the need to scroll to the top to press the "Select" button.
Key Features:
Behavior:
Testing
✅ All 4044 tests pass (includes 22 new useLongPress tests)
✅ Build succeeds with no TypeScript errors
Test Coverage
Original Commits
This PR incorporates the following orphaned commits:
b88e3fc- feat: implement tap & hold to select shelf items990c8aa- fix: implement @review feedback (iteration 1)f623bb4- fix: add onTouchCancel handler and Enter key accessibility supportReferences
Resolves: #414
Fixes: #415