Skip to content

Add a long-missed new in the tutorial#275

Merged
masak merged 1 commit into
masterfrom
tutorial-fix
Feb 10, 2018
Merged

Add a long-missed new in the tutorial#275
masak merged 1 commit into
masterfrom
tutorial-fix

Conversation

@masak

@masak masak commented Feb 10, 2018

Copy link
Copy Markdown
Owner

Siphoned off of #242, as promised. Creating a PR for this because, all other things equal, I like the papertrail that PRs create.

Of course, all this is putting lipstick on a pig a little bit. We want to #67 real soon now.

@masak

masak commented Feb 10, 2018

Copy link
Copy Markdown
Owner Author

It would be Nice™ in the long run to have all the code examples in the tutorial (or equivalent) tested as part of the unit tests. Making sure they compile would've caught the thing in this PR.

@masak masak merged commit 87a500d into master Feb 10, 2018
@masak masak deleted the tutorial-fix branch February 10, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant