Release v0.3.0: configurable callout/highlight colors + world-scoped settings by martin-papy · Pull Request #15 · martin-papy/markdown-paste

martin-papy · 2026-05-29T04:53:32Z

Summary

Promotes develop to main for the v0.3.0 release. Two feature branches landed since v0.2.1 (feature-highlight-syntax #13, feature-settings #14), plus tooling and docs.

Added

Customizable callout & highlight colors via a new "Configure colors" settings menu — 13 callout pickers with live preview and reset-to-defaults. Colors apply retroactively to all callouts/highlights for every user. (callout-color-menu.js, callout-colors.js, templates/callout-color-menu.hbs)
"Allow non-GM players to use Paste Markdown" option. Off by default (GM-only); per-surface toggles still apply.
Obsidian ==highlight== now renders as , themeable via the new color setting.
ESLint with flat config (eslint.config.js).

Changed

All module settings are now world-scoped and GM-controlled (previously per-client).

Tooling / Docs

release.sh: sync package.json version with module.json; include templates/ in the release zip.
Design spec + implementation plan under docs/superpowers/.

Test plan

npm test passes (new suites: callout-colors.test.js, menu-button.test.js, extended convert/obsidian tests)
CHANGELOG has [0.3.0] - 2026-05-29 entry (validated by release.sh)
Manual smoke test in Foundry v13/v14: open colors menu, change a color, verify live preview + retroactive apply
Verify non-GM gating with "Allow non-GM" off and on

Release follow-up

After merge, run ./release.sh from main to tag v0.3.0 and trigger the FoundryVTT publish workflow.

Adds transformHighlights() to obsidian.js which replaces ==text== with text before markdown parsing. Wired into the Obsidian processing pipeline in convert(), controlled by the existing processObsidian setting. Updates dialog and settings hints in en/fr. Closes #12

feat: support Obsidian ==highlight== syntax as elements

…to packaging

…Paste Settings

…to top of module settings panel

…ttern (footer part, _preparePartContext); move menu to bottom

…d collided with the injected style element)

…d-highlight class

The colors = {} default only catches undefined, not null. A cleared or corrupted calloutColors setting (passed via applyCalloutColors on ready) would make colors[type] / colors.highlight throw. Coerce non-objects to {}.

The .md-highlight rule hardcoded color: #000, which is unreadable on dark user-chosen --md-highlight-bg values. Compute a WCAG-luminance foreground (#000/#fff) in buildCalloutColorCss, emit --md-highlight-fg, and consume it in CSS with a #000 fallback for the pre-palette state.

Settings improvements: GM-controlled world settings, callout & highlight colors

coderabbitai · 2026-05-29T04:53:40Z

Warning

Review limit reached

@martin-papy, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 14 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8a3ba0c9-31a0-4d06-a581-a365361a6271

📥 Commits

Reviewing files that changed from the base of the PR and between 549712a and d395ba4.

⛔ Files ignored due to path filters (10)

CHANGELOG.md is excluded by !**/*.md and included by **/*
CLAUDE.md is excluded by !**/*.md and included by **/*
README.md is excluded by !**/*.md and included by **/*
docs/superpowers/plans/2026-05-29-settings-improvements.md is excluded by !**/*.md and included by **/*
docs/superpowers/specs/2026-05-29-settings-improvements-design.md is excluded by !**/*.md and included by **/*
images/Settings.png is excluded by !**/*.png and included by **/*
tests/callout-colors.test.js is excluded by !**/tests/** and included by **/*
tests/convert.test.js is excluded by !**/tests/** and included by **/*
tests/menu-button.test.js is excluded by !**/tests/** and included by **/*
tests/obsidian.test.js is excluded by !**/tests/** and included by **/*

📒 Files selected for processing (15)

.github/workflows/release.yml
eslint.config.js
lang/en.json
lang/fr.json
package.json
release.sh
scripts/callout-color-menu.js
scripts/callout-colors.js
scripts/convert.js
scripts/main.js
scripts/menu-button.js
scripts/obsidian.js
scripts/settings.js
styles/markdown-paste.css
templates/callout-color-menu.hbs

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

martin-papy added 29 commits May 29, 2026 07:00

chore: add ESLint with flat config and fix useless escape in obsidian.js

e0e33fb

Merge pull request #13 from martin-papy/feature-highlight-syntax

4e5a8a4

feat: support Obsidian ==highlight== syntax as elements

docs: settings improvements design spec

e01c2b0

docs: use Handlebars template for callout-color form, add templates/ …

33aa0ff

…to packaging

docs: settings improvements implementation plan

1aa9b51

feat: add pure callout-color CSS builder and injector

43312d4

refactor: export CALLOUT_EMOJI for the callout-color form

920f816

feat: make settings world-scoped, add allowNonGM and calloutColors

7882563

feat: gate the Paste Markdown button behind allowNonGM for non-GMs

9381390

feat: add callout-color form template

56f79cc

feat: add CalloutColorMenu sub-form and registerMenu registration

a44c9a0

feat: register color menu, settings heading, and apply colors on ready

76980ac

style: add settings heading and callout-color menu styles

212f1dd

i18n: add settings heading, allowNonGM, and callout-color strings

a005cbb

build: include templates/ in the release zip

612e8d5

docs: changelog for settings improvements

a2107f2

i18n: make allowNonGM hint position-independent

e0a4b34

build: sync package.json version with module.json in release.sh

e61b7fe

fix: move allowNonGM to first setting and rename heading to Markdown …

46f5dca

…Paste Settings

fix: open callout-colors form via direct click handler; move heading …

5ea59e5

…to top of module settings panel

fix: align callout-colors menu with working ApplicationV2 settings pa…

b00e823

…ttern (footer part, _preparePartContext); move menu to bottom

fix: give callout-color form a distinct id so it inserts into body (i…

496d746

…d collided with the injected style element)

feat: configurable highlight () color in the colors menu with m…

ae18e1d

…d-highlight class

docs: changelog for configurable highlight color

3f80613

fix: guard buildCalloutColorCss against null colors argument

f4ea187

The colors = {} default only catches undefined, not null. A cleared or corrupted calloutColors setting (passed via applyCalloutColors on ready) would make colors[type] / colors.highlight throw. Coerce non-objects to {}.

Merge pull request #14 from martin-papy/feature-settings

ace27b8

Settings improvements: GM-controlled world settings, callout & highlight colors

chore: prepare release v0.3.0

d395ba4

martin-papy merged commit 56ec0ef into main May 29, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release v0.3.0: configurable callout/highlight colors + world-scoped settings#15

Release v0.3.0: configurable callout/highlight colors + world-scoped settings#15
martin-papy merged 29 commits into
mainfrom
develop

martin-papy commented May 29, 2026

Uh oh!

coderabbitai Bot commented May 29, 2026

Review limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

martin-papy commented May 29, 2026

Summary

Added

Changed

Tooling / Docs

Test plan

Release follow-up

Uh oh!

coderabbitai Bot commented May 29, 2026

Review limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant