Preserve rhythm symbols in chords-over-words lines#2214
Open
aouxwoux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve rhythm-symbol metadata when a chords-over-words chord line is paired with a lyric line.
The parser already marked
/,|,-, andxas rhythm symbols on chord-only lines, and the HTML formatters already render those items with the configuredrhythm-symbolclass. In the mixed chords-over-words path, those items were cast through the chord-only type and lostisRhythmSymbol, so they rendered as regular chords.This keeps the original item type through lyric pairing and sets
isRhythmSymbolfor rhythm markers there too.Part of #2070.
Validation
yarn eslint src/parser/chords_over_words/helpers.ts test/parser/chords_over_words_parser.test.tsyarn jest test/parser/chords_over_words_parser.test.ts test/formatter/html_table_formatter.test.ts test/formatter/html_div_formatter.test.ts --runInBand