Skip to content

Correct MIC source mapping for E‑Test/Vitek and add regression coverage for Voriconazole dropdowns#234

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-breachpoints-values-mapping
Draft

Correct MIC source mapping for E‑Test/Vitek and add regression coverage for Voriconazole dropdowns#234
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-breachpoints-values-mapping

Conversation

Copilot AI commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Reported behavior: E‑Test rows (notably Voriconazole) could display MIC options that match Vitek-style lists for certain row combinations. This points to a method/agent mapping inconsistency in breakpoint-driven dropdown population.

  • Configuration mapping correction

    • Fixed an incorrect antifungal key in NRZMyk.Services/Configuration/BreakpointSettings.json under MicSteps.Vitek.
    • The key was Fluorouracil but the configured value set belongs to Flucytosine, which breaks enum-keyed mapping consistency used by MIC lookup.
  • Regression test for the reported UI symptom

    • Added a component-level regression test in NRZMyk.Components.Tests/Pages/SentinelEntryPage/CreateTests.cs that models mixed Vitek/E‑Test Voriconazole rows and row removal.
    • The test asserts the remaining E‑Test Voriconazole row keeps E‑Test MIC options and does not drift to Vitek options.
  • Test fixture support for method-specific MIC data

    • Added a method-specific test IMicStepsService implementation in the test file to explicitly separate Vitek vs E‑Test Voriconazole MIC lists and make the regression deterministic.
// BreakpointSettings.json (MicSteps.Vitek)
- "Fluorouracil": [ ... ]
+ "Flucytosine": [ ... ]
eTestMicValues.Should().Contain("≤0,008");
eTestMicValues.Should().Contain("0,06");
eTestMicValues.Should().NotContain("≤0,12");

Copilot AI changed the title Fix incorrect Vitek MIC mapping key in breakpoint settings Correct MIC dropdown mapping for E‑Test/Vitek by fixing antifungal key in breakpoint config Jun 30, 2026
Copilot AI requested a review from markusrt June 30, 2026 06:06
Copilot AI changed the title Correct MIC dropdown mapping for E‑Test/Vitek by fixing antifungal key in breakpoint config Correct MIC source mapping for E‑Test/Vitek and add regression coverage for Voriconazole dropdowns Jun 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants