fix(tests): align RepoManagementScriptsTest with batched gh repo list#60
Merged
Conversation
The split-repo optimization in #56 replaced per-package `gh repo view` calls with a single batched `gh repo list` lookup and silent skip path. The assertions in `it('skips repos that already exist without erroring')` were still checking for the old literal strings (`gh repo view`, `already exists, skipping`) and failing on develop. Update assertions to match the current script wording. Also normalize two pre-existing multiline-call lint violations in the same file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh repo viewcalls inbin/create-split-repos.shwith a single batchedgh repo listlookup and a silent skip pathRepoManagementScriptsTest::it('skips repos that already exist without erroring')still asserted the old literal strings (gh repo view,already exists, skipping) and has been failing on develop sincegh repo list,Already exists)RequireMultiLineCalllint violations in the same file (per the "fix all lint in touched files" policy)Test plan
composer test— 4895 passed, 0 failed./vendor/bin/phpcs tests/RepoManagementScriptsTest.php— clean🤖 Generated with Claude Code