Skip to content

Refactor invisible captcha tests to use travel instead of sleep for timestamp handling #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markets merged 1 commit into from
Jul 15, 2026
Merged

Refactor invisible captcha tests to use travel instead of sleep for timestamp handling #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions spec/controllers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
InvisibleCaptcha.spinner_enabled = false
end

after(:each) { travel_back }

context 'without invisible_captcha_timestamp in session' do
it 'fails like if it was submitted too fast' do
post :create, params: { topic: { title: 'foo' } }
Expand Down Expand Up @@ -87,7 +89,7 @@ def custom_timestamp_callback

context 'successful submissions' do
it 'passes if submission on or after timestamp_threshold' do
sleep InvisibleCaptcha.timestamp_threshold
travel InvisibleCaptcha.timestamp_threshold

post :create, params: {
topic: {
Expand All @@ -105,7 +107,7 @@ def custom_timestamp_callback
end

it 'allow to set a custom timestamp_threshold per action' do
sleep 2 # custom threshold
travel 2 # custom threshold

post :publish, params: { id: 1 }

Expand All @@ -126,7 +128,7 @@ def custom_timestamp_callback
session[:invisible_captcha_timestamp] = Time.zone.now.iso8601

# Wait for valid submission
sleep InvisibleCaptcha.timestamp_threshold
travel InvisibleCaptcha.timestamp_threshold
end

it 'fails with spam' do
Expand Down Expand Up @@ -237,7 +239,7 @@ def custom_timestamp_callback
session[:invisible_captcha_timestamp] = Time.zone.now.iso8601

# Wait for valid submission
sleep InvisibleCaptcha.timestamp_threshold
travel InvisibleCaptcha.timestamp_threshold
end

after(:each) { InvisibleCaptcha.honeypot_enabled = true }
Expand Down Expand Up @@ -265,7 +267,7 @@ def custom_timestamp_callback
session[:invisible_captcha_spinner] = spinner_value

# Wait for valid submission
sleep InvisibleCaptcha.timestamp_threshold
travel InvisibleCaptcha.timestamp_threshold
end

it 'fails with no spam, but mismatch of spinner' do
Expand Down
Loading