Skip to content

Upgrade spinner token comparison logic for hardened constant-time security#152

Merged
markets merged 2 commits into
markets:masterfrom
dmrAnderson:upgrade-spinner-token-comparison-security
Jul 13, 2026
Merged

Upgrade spinner token comparison logic for hardened constant-time security#152
markets merged 2 commits into
markets:masterfrom
dmrAnderson:upgrade-spinner-token-comparison-security

Conversation

@dmrAnderson

@dmrAnderson dmrAnderson commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
  • Replaced standard string comparison with a secure, constant-time comparison to prevent potential timing attacks.
    While the practical risk here is low, upgrading to a constant-time comparison is a zero-cost fix that aligns with standard Rails security conventions.
  • Fix flaky timestamp-threshold specs. Relied on real elapsed time staying under the 1s threshold.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (b0093de) to head (f998d02).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   98.44%   98.57%   +0.13%     
==========================================
  Files          22       22              
  Lines         449      492      +43     
==========================================
+ Hits          442      485      +43     
  Misses          7        7              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmrAnderson
dmrAnderson force-pushed the upgrade-spinner-token-comparison-security branch from 8d991b9 to 4efcbd5 Compare July 11, 2026 15:07
@markets
markets merged commit 727d33b into markets:master Jul 13, 2026
20 checks passed
@dmrAnderson
dmrAnderson deleted the upgrade-spinner-token-comparison-security branch July 13, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants