Skip to content

Consume spinner token from session#151

Merged
markets merged 1 commit into
markets:masterfrom
dmrAnderson:fix/consume-spinner-session-token
Jul 9, 2026
Merged

Consume spinner token from session#151
markets merged 1 commit into
markets:masterfrom
dmrAnderson:fix/consume-spinner-session-token

Conversation

@dmrAnderson

@dmrAnderson dmrAnderson commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Currently, the invisible_captcha_timestamp is explicitly consumed and removed from the session during validation, but the invisible_captcha_spinner is only read.

While this doesn't impact failed/spam requests, it creates an issue on successful form submissions.
Because the invisible_captcha_spinner token is never deleted, it lingers in the user's session cookie indefinitely as stale data.

@markets

markets commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Hey @dmrAnderson I think we already delete this value in another place:

timestamp = session.delete(:invisible_captcha_timestamp)

Not sure if this is necessary 🤔

@dmrAnderson

dmrAnderson commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Hi!
Thanks for the quick reply!
During a successful request:

  • invisible_captcha_timestamp is cleanly deleted from the session.
  • invisible_captcha_spinner is verified, but remains in the session.

@dmrAnderson
dmrAnderson force-pushed the fix/consume-spinner-session-token branch from 8c391d9 to e1fa98b Compare July 8, 2026 21:50
@markets
markets merged commit 108dce5 into markets:master Jul 9, 2026
20 checks passed
@dmrAnderson
dmrAnderson deleted the fix/consume-spinner-session-token branch July 9, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants