Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/reactionview/template/handlers/herb/herb.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def add_rails_expression(indicator, code, wrap_parentheses:)
end

if wrap_parentheses
@src << "(" << code << ")"
@src << "(" << code << "\n)"
else
@src << " " << code
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
@output_buffer.safe_append='<h1>Hello '.freeze; @output_buffer.append=(@name); @output_buffer.safe_append='</h1>'.freeze;
@output_buffer.safe_append='<h1>Hello '.freeze; @output_buffer.append=(@name
); @output_buffer.safe_append='</h1>'.freeze;
@output_buffer
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
@output_buffer.append=(@html); @output_buffer.append=(raw @safe_html);
@output_buffer.append=(@html
); @output_buffer.append=(raw @safe_html
);
@output_buffer
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@output_buffer.safe_append='<div>
'.freeze; @output_buffer.append=(@content); @output_buffer.safe_append='
'.freeze; @output_buffer.append=(@content
); @output_buffer.safe_append='
</div>'.freeze;
@output_buffer
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
@output_buffer.safe_append='<h1>Hello '.freeze; @output_buffer.append=(@name); @output_buffer.safe_append='!</h1><p>'.freeze; @output_buffer.append=(@message); @output_buffer.safe_append='</p>'.freeze;
@output_buffer.safe_append='<h1>Hello '.freeze; @output_buffer.append=(@name
); @output_buffer.safe_append='!</h1><p>'.freeze; @output_buffer.append=(@message
); @output_buffer.safe_append='</p>'.freeze;
@output_buffer
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
@output_buffer.safe_append='<div>'.freeze; @output_buffer.append=(@unsafe_content); @output_buffer.safe_append='</div>'.freeze;
@output_buffer.safe_append='<div>'.freeze; @output_buffer.append=(@unsafe_content
); @output_buffer.safe_append='</div>'.freeze;
@output_buffer
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
@output_buffer.append=(content_tag :div, "Hello", class: "greeting");
@output_buffer.append=(content_tag :div, "Hello", class: "greeting"
);
@output_buffer
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
@output_buffer.safe_append='<div class="user-card">
<h2>'.freeze; @output_buffer.append=(@user[:name]); @output_buffer.safe_append='</h2>
<h2>'.freeze; @output_buffer.append=(@user[:name]
); @output_buffer.safe_append='</h2>
'.freeze; if @user[:verified]
@output_buffer.safe_append=' <span class="badge">Verified</span>
'.freeze; end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
@output_buffer.safe_append='<div class="container py-8">
<h1 class="title">'.freeze; @output_buffer.append=(title "Events by Country"); @output_buffer.safe_append='</h1>
<h1 class="title">'.freeze; @output_buffer.append=(title "Events by Country"
); @output_buffer.safe_append='</h1>

'.freeze; @output_buffer.append=(ui_button "View all cities", url: cities_path, kind: :secondary); @output_buffer.safe_append='
'.freeze; @output_buffer.append=(ui_button "View all cities", url: cities_path, kind: :secondary
); @output_buffer.safe_append='

'.freeze; if @show_countries
@output_buffer.safe_append=' <h2>Countries</h2>
'.freeze; @output_buffer.append= link_to country_path("switzerland"), id: "country-ch", class: "event-item" do; @output_buffer.safe_append='
<span class="event-name">🇨🇭 Switzerland</span>
'.freeze; @output_buffer.append=(ui_badge(5, kind: :secondary, class: "event-count")); @output_buffer.safe_append='
'.freeze; @output_buffer.append=(ui_badge(5, kind: :secondary, class: "event-count")
); @output_buffer.safe_append='
'.freeze; end
end
@output_buffer.safe_append='</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
@output_buffer.append=(method_call <<~GRAPHQL, variables
query {
field
}
GRAPHQL
);
@output_buffer.safe_append='
'.freeze;@output_buffer
13 changes: 13 additions & 0 deletions test/template/handlers/herb_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -342,4 +342,17 @@ def @view_context.ui_badge(count, **_options)
assert_compiled_snapshot(template)
assert_evaluated_snapshot(template, ivars: { config: { key: "value" } })
end

test "heredoc with trailing arguments compiles to valid Ruby" do
template = <<~ERB
<%= method_call <<~GRAPHQL, variables
query {
field
}
GRAPHQL
%>
ERB

assert_compiled_snapshot(template)
Comment thread
marcoroth marked this conversation as resolved.
end
end