Add HERB_EXPORTED_FUNCTION macro for symbol visibility control

.clang-format

@@ -20,6 +20,7 @@ ColumnLimit: 120
 ContinuationIndentWidth: 2
 Cpp11BracedListStyle: false
 IndentCaseLabels: true
+IndentPPDirectives: AfterHash
 IndentWidth: 2
 InsertBraces: true
 InsertNewlineAtEOF: true

ext/herb/extconf.rb

@@ -24,7 +24,6 @@
 $INCFLAGS << " -I#{prism_src_path}"
 $INCFLAGS << " -I#{prism_src_path}/util"
 
-$CFLAGS << " -DPRISM_EXPORT_SYMBOLS=static"
 $CFLAGS << " -fvisibility=hidden"
 
 herb_src_files = Dir.glob("#{$srcdir}/../../src/**/*.c").map { |file| file.delete_prefix("../../../../ext/herb/") }.sort

ext/herb/extension.c

@@ -124,7 +124,7 @@ static VALUE Herb_version(VALUE self) {
   return rb_funcall(rb_mKernel, rb_intern("sprintf"), 4, format_string, gem_version, libprism_version, libherb_version);
 }
 
-__attribute__((visibility("default"))) void Init_herb(void) {
+__attribute__((__visibility__("default"))) void Init_herb(void) {
   mHerb = rb_define_module("Herb");
   cPosition = rb_define_class_under(mHerb, "Position", rb_cObject);
   cLocation = rb_define_class_under(mHerb, "Location", rb_cObject);

src/herb.c

@@ -10,7 +10,7 @@
 #include <prism.h>
 #include <stdlib.h>
 
-hb_array_T* herb_lex(const char* source) {
+HERB_EXPORTED_FUNCTION hb_array_T* herb_lex(const char* source) {
   lexer_T lexer = { 0 };
   lexer_init(&lexer, source);
 
@@ -26,7 +26,7 @@ hb_array_T* herb_lex(const char* source) {
   return tokens;
 }
 
-AST_DOCUMENT_NODE_T* herb_parse(const char* source, parser_options_T* options) {
+HERB_EXPORTED_FUNCTION AST_DOCUMENT_NODE_T* herb_parse(const char* source, parser_options_T* options) {
   if (!source) { source = ""; }
 
   lexer_T lexer = { 0 };
@@ -46,7 +46,7 @@ AST_DOCUMENT_NODE_T* herb_parse(const char* source, parser_options_T* options) {
   return document;
 }
 
-hb_array_T* herb_lex_file(const char* path) {
+HERB_EXPORTED_FUNCTION hb_array_T* herb_lex_file(const char* path) {
   char* source = herb_read_file(path);
   hb_array_T* tokens = herb_lex(source);
 
@@ -55,7 +55,7 @@ hb_array_T* herb_lex_file(const char* path) {
   return tokens;
 }
 
-void herb_lex_to_buffer(const char* source, hb_buffer_T* output) {
+HERB_EXPORTED_FUNCTION void herb_lex_to_buffer(const char* source, hb_buffer_T* output) {
   hb_array_T* tokens = herb_lex(source);
 
   for (size_t i = 0; i < hb_array_size(tokens); i++) {
@@ -71,7 +71,7 @@ void herb_lex_to_buffer(const char* source, hb_buffer_T* output) {
   herb_free_tokens(&tokens);
 }
 
-void herb_free_tokens(hb_array_T** tokens) {
+HERB_EXPORTED_FUNCTION void herb_free_tokens(hb_array_T** tokens) {
   if (!tokens || !*tokens) { return; }
 
   for (size_t i = 0; i < hb_array_size(*tokens); i++) {
@@ -82,10 +82,10 @@ void herb_free_tokens(hb_array_T** tokens) {
   hb_array_free(tokens);
 }
 
-const char* herb_version(void) {
+HERB_EXPORTED_FUNCTION const char* herb_version(void) {
   return HERB_VERSION;
 }
 
-const char* herb_prism_version(void) {
+HERB_EXPORTED_FUNCTION const char* herb_prism_version(void) {
   return PRISM_VERSION;
 }

src/include/herb.h

@@ -3,6 +3,7 @@
 
 #include "ast_node.h"
 #include "extract.h"
+#include "macros.h"
 #include "parser.h"
 #include "util/hb_array.h"
 #include "util/hb_buffer.h"
@@ -13,17 +14,17 @@
 extern "C" {
 #endif
 
-void herb_lex_to_buffer(const char* source, hb_buffer_T* output);
+HERB_EXPORTED_FUNCTION void herb_lex_to_buffer(const char* source, hb_buffer_T* output);
 
-hb_array_T* herb_lex(const char* source);
-hb_array_T* herb_lex_file(const char* path);
+HERB_EXPORTED_FUNCTION hb_array_T* herb_lex(const char* source);
+HERB_EXPORTED_FUNCTION hb_array_T* herb_lex_file(const char* path);
 
-AST_DOCUMENT_NODE_T* herb_parse(const char* source, parser_options_T* options);
+HERB_EXPORTED_FUNCTION AST_DOCUMENT_NODE_T* herb_parse(const char* source, parser_options_T* options);
 
-const char* herb_version(void);
-const char* herb_prism_version(void);
+HERB_EXPORTED_FUNCTION const char* herb_version(void);
+HERB_EXPORTED_FUNCTION const char* herb_prism_version(void);
 
-void herb_free_tokens(hb_array_T** tokens);
+HERB_EXPORTED_FUNCTION void herb_free_tokens(hb_array_T** tokens);
 
 #ifdef __cplusplus
 }

src/include/macros.h

@@ -1,6 +1,14 @@
 #ifndef HERB_MACROS_H
 #define HERB_MACROS_H
 
+#ifndef HERB_EXPORTED_FUNCTION
+#  ifdef HERB_EXPORT_SYMBOLS
+#    define HERB_EXPORTED_FUNCTION __attribute__((__visibility__("default"))) extern
+#  else
+#    define HERB_EXPORTED_FUNCTION
+#  endif
+#endif
+
 #define MAX(a, b) ((a) > (b) ? (a) : (b))
 
 #define MIN(a, b) ((a) < (b) ? (a) : (b))

src/util/hb_system.c

@@ -1,13 +1,13 @@
 #include "../include/util/hb_system.h"
 
 #ifdef __linux__
-#define _GNU_SOURCE
+#  define _GNU_SOURCE
 #endif
 
 #ifdef HB_USE_MALLOC
-#include <stdlib.h>
+#  include <stdlib.h>
 #else
-#include <sys/mman.h>
+#  include <sys/mman.h>
 #endif
 
 void* hb_system_allocate_memory(size_t size) {