Parser: Re-parse on unexpected ";" error for more accurate errors#902
Merged
Conversation
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
Contributor
|
@marcoroth do you have a plan for a new release including this? I've still used v0.7 because of this bug. It would be very helpful if 0.8.3 released. |
Owner
Author
|
Hey @tk0miya, sorry for the delay. I just got back home from the San Francisco Ruby Conference. I'm planning on releasing a new Herb version later today! 🙌🏼 |
Contributor
|
Oh, I don't know that. I'm not in a hurry, so please work on it at your own leisure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the way the parser handles the
unexpected ";"errors.In #824, we changed the
herb_extract_ruby_to_buffer_with_semicolonsmethod to only add semicolons when needed. This pull request reverts that. But instead of just outputting theunexpected ";"errors (as it was before #824), we check if the;was actually part of the source file.If it wasn't part of the source file we re-parse this individual
ERBContentNodeto check for syntax errors in the raw source of thatERBContentNodeinstead, which shouldn't have the semicolon and thus shouldn't append theunexpected ";"errors.Resolves #854
Resolves #865
Resolves #899