Fix missing loadConfig-export#876
Closed
andreaslillebo wants to merge 3 commits into
Closed
Conversation
Owner
|
Thanks @andreaslillebo, I'm not sure what the best way to test this is. I'll have to do some manual testing! Thank you! |
marcoroth
added
the
release-preview
commit: |
Owner
|
Hey @andreaslillebo, thanks for checking this out, sadly it was a bigger feat and I opened #892 instead. Thanks for giving this a shot! 🙏🏼 |
Author
|
You're welcome. Thanks for fixing this so fast 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #852, #875
Tailwind V4 removed some exports, causing
ERR_PACKAGE_PATH_NOT_EXPORTEDwhen trying to import them.I fixed this by making these imports dynamic, where we try to load v4 dependencies first, and fall back on v3 when not found.
I have not added any tests, as I'm not sure how to best test this.