JavaScript: Use tinyglobby and picomatch#843
Merged
Merged
Conversation
github-actions
Bot
added
linter
formatter
javascript
typescript
printer
config
rewriter
labels
marcoroth
force-pushed
the
tinyglobby-picomatch
branch
from
f2d038a to
eea9915
Compare
Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.106.0 to 1.107.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
marcoroth
force-pushed
the
tinyglobby-picomatch
branch
from
eea9915 to
545b0c8
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This was referenced Jan 16, 2026
marcoroth
added a commit
that referenced
this pull request
Jan 16, 2026
This pul request fixes an issue introduced by the `tinyglobby` migration in #843. The linter CLI incorrectly processed files outside the specified directory when running commands like `herb-lint app/views`. This was caused by the glob pattern construction producing `app/views/{**/*.html,**/*.html.erb}` which `tinyglobby` doesn't support. The fix now correctly produces `{app/views/**/*.html,app/views/**/*.html.erb}` by prepending the directory path to each pattern individually before joining them. Additionally migrates the custom rule loader from the old `glob` package to `tinyglobby` for consistency. Resolves #1045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the use of
globtotinyglobbyandminimatchtopicomatchin all JavaScript packages.