Docs: Note multi-attribute wrap behavior on maxLineLength#1823
Merged
marcoroth merged 1 commit intoJun 28, 2026
Merged
Conversation
The formatter wraps tags with more than 3 attributes one-per-line regardless of maxLineLength. Surface this on the maxLineLength option so users aren't surprised when short multi-attribute tags wrap. Refs marcoroth#928
marcoroth
approved these changes
Jun 28, 2026
marcoroth
left a comment
marcoroth
left a comment
Owner
There was a problem hiding this comment.
Thanks @andy-rootly! 🙏🏼
I wonder if we should reconsider this rule and only wrap the attributes when they wouldn't fit within the maxLineLength.
I'm open to suggestions.
marcoroth
changed the title
maxLineLength
2 tasks
Contributor
Author
Yeah, that make sense to me: #1834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter wraps tags one-attribute-per-line under two conditions (see
attribute-renderer.ts#L91):maxLineLength, OROnly the first is documented today. The second can be surprising in practice —
<div a="1" b="2" c="3" d="4">wraps even though it's 36 characters wide, well under the 80-char default. This PR adds a short note on themaxLineLengthoption flagging the count rule.The docs site (
docs/docs/projects/formatter.md)@includes this README, so herb-tools.dev picks the change up automatically.