Parser: Add max_errors to parse_option_T#1796
Merged
Merged
Conversation
marcoroth
changed the title
max_errors to parse_option_T
github-actions
Bot
added
linter
parser
ruby
wasm
typescript
c
c-extension
rbs
rubygem
rust
java
core
cpp
labels
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
max_errorsargument toparse_option_TandHerb.parseso that the parser stops generating errors after the limit is reached. It defaults to 25 but can be overwritten by passing themax_errorskeyword argument toHerb.parse:Setting
max_errorstonildisables the limit.This prevents pathological inputs (e.g. thousands of unclosed tags) from generating thousands of error objects, which wastes memory and produces output no one will read.
Follow-up to #1795.