Skip to content

Dev Tools: Show warnings for Compile-Time Optimization Mismatches#1660

Merged
marcoroth merged 1 commit into
mainfrom
dev-tools-mismatches
Apr 20, 2026
Merged

Dev Tools: Show warnings for Compile-Time Optimization Mismatches#1660
marcoroth merged 1 commit into
mainfrom
dev-tools-mismatches

Conversation

@marcoroth

@marcoroth marcoroth commented Apr 20, 2026

Copy link
Copy Markdown
Owner

This pull request adds compile-time optimization mismatch detection and reporting to the Herb dev tools.

When verify_optimizations is enabled in ReActionView, the template handler compiles each template twice on first render, once with optimizations and once without, and compares the output. If the results differ, a <template data-herb-optimization-mismatch> marker is injected into the page.

The dev tools detect these markers and display a warning badge (⚠️) next to the Herb floating menu. Clicking the badge shows a panel listing the affected templates by relative path. Full diff details are logged to the Rails server log.

CleanShot 2026-04-20 at 13 08 24@2x

@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


🌱 Grown from commit b55e25d


✅ Preview deployment has been cleaned up.

@pkg-pr-new

pkg-pr-new Bot commented Apr 20, 2026

Copy link
Copy Markdown
npx https://pkg.pr.new/@herb-tools/formatter@1660
npx https://pkg.pr.new/@herb-tools/language-server@1660
npx https://pkg.pr.new/@herb-tools/linter@1660

commit: b55e25d

@marcoroth marcoroth merged commit 0a7972e into main Apr 20, 2026
26 of 27 checks passed
@marcoroth marcoroth deleted the dev-tools-mismatches branch April 20, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant