JavaScript: Remove registry-url to allow trusted publishing to NPM#1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob usedactions/setup-nodewithregistry-url, which automatically setsNODE_AUTH_TOKENto the GitHub token. npm then tried to authenticate with that GitHub token against the npm registry, which npm doesn't recognize, resulting in a 404.The OIDC provenance signing worked fine (it uses a separate code path), but the actual publish authentication never fell through to the OIDC trusted publishing flow because
NODE_AUTH_TOKENwas already set.Removing
registry-urlshould preventsetup-nodefrom creating the.npmrcand settingNODE_AUTH_TOKEN, so npm defaults to its OIDC-based authentication when--provenanceis used withid-token: write.