Config: Fix rule-level patterns for matching absolute file paths#1645
Merged
Conversation
marcoroth
force-pushed
the
normalize-absolute-file-paths-for-rule-patterns
branch
from
b195947 to
8e36aa6
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule-level
exclude,include, andonlypatterns in.herb.ymlsilently failed when the linter received an absolute file path (e.g., from the VS Code extension).The glob patterns are relative (e.g.,
app/views/layouts/jasmine.*), butpicomatch/globsetwon't match them against absolute paths like/home/user/project/app/views/layouts/jasmine.html.erb.This adds path normalization in both the JavaScript and Rust config packages. When a file path is absolute and starts with the project path, it gets stripped to a relative path before pattern matching.
Might fix #1630