Linter: Access rule type from class instead of instance#1298
Merged
Conversation
marcoroth
changed the title
type from class instead of instance
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the linter by accessing the
static typefield directly on rule classes instead of instantiating rules and reading it fromrule.constructor.The instance-level type guards (
isLexerRule,isSourceRule,isParserRule) are replaced with class-level equivalents (isLexerRuleClass,isSourceRuleClass,isParserRuleClass) that take aruleClassrather than a Rule instance.It also extracts a
findRuleClass(ruleName)helper to deduplicate the six occurrences ofthis.rules.find(rule => rule.ruleName === ...), and renamesRuleClasslocal variables toruleClassto follow camelCase conventions for non-type identifiers.Follow up on #1268