Formatter: Extract Text Flow Engine#1267
Merged
Merged
Conversation
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
169ac97 to
65d848e
Compare
marcoroth
added a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extracts the text flow formatting system from
FormatPrinterinto a dedicatedTextFlowEngineclass and pure helper functions. The text flow system handles formatting of mixed text + inline elements + ERB content with intelligent word wrapping and punctuation handling.This is mostly motived be the number of bugs we have seen around inline text formatting and punctuation. Related issues:
<br>tag recursively #588div > spanare combined into a single line #882The hope is that, extracting the text flow engine, makes the formatter easier to test and reason about.