Ruby: Don't run tests with forking threads by default#1255
Merged
Conversation
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
marcoroth
force-pushed
the
test-forking
branch
from
a455f99 to
2b965d3
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Ruby test suite to not require the
fork_helperin a normal run. Initially, we added the forking helpers so we could isolate segfaults in the Parser/Ruby native extension when running the full test suite.But this hasn't been happening a lot anymore, so the more than 2x slowdown is not worth to have on regular runs.
Instead, we rename/flip the
NO_TIMEOUTtoFORK_TESTS. If we are not forking, we are now showing a message to remind people that they could be running the tests in forking mode by passing the newFORK_TESTSenvironment variable to isolate a potential crash/segfault in one of the tests.