Skip to content

🔒 fix: secure randomness for spin wheel code generation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcin2121 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 fix: secure randomness for spin wheel code generation #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions app/actions/spin-wheel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,14 @@ export async function spinWheel() {

// 4. ALGORYTM LOSOWANIA (Ważony) z puli tylko dostępnych nagród
const totalWeight = availablePrizes.reduce((sum: number, p: any) => sum + Number(p.chance), 0)
let randomNum = Math.random() * totalWeight

// Używamy bezpiecznego generatora liczb losowych zamiast Math.random()
const cryptoRandomBuffer = new Uint32Array(1);
crypto.getRandomValues(cryptoRandomBuffer);
// Przekształcamy uint32 (0 do 0xFFFFFFFF) na float [0, 1)
const secureRandomFloat = cryptoRandomBuffer[0] / (0xFFFFFFFF + 1);

let randomNum = secureRandomFloat * totalWeight;
let winningPrize = availablePrizes[0]

for (const prize of availablePrizes) {
Expand All @@ -71,7 +78,16 @@ export async function spinWheel() {
}

// 5. Generujemy unikalny kod kuponu (np. BONUS10-A4B9)
const randomSuffix = Math.random().toString(36).substring(2, 6).toUpperCase()
// Bezpieczne generowanie 4 znaków z bazy 36 (A-Z, 0-9)
const charset = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ';
const suffixBuffer = new Uint8Array(4);
crypto.getRandomValues(suffixBuffer);

let randomSuffix = '';
for (let i = 0; i < 4; i++) {
randomSuffix += charset[suffixBuffer[i] % charset.length];
}

const finalCode = `${winningPrize.code_prefix}-${randomSuffix}`

// 6. Zapisujemy wylosowany kupon dla użytkownika
Expand Down