Fix #29: Email validation accepts missing domain suffix#34
Draft
github-actions[bot] wants to merge 2 commits into
Draft
Fix #29: Email validation accepts missing domain suffix#34github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Generated by posthog-watcher-action using pi.
Summary
The
/users/validate-emailendpoint delegates toisValidEmail, whose regex only requires non-whitespace text on both sides of@, so addresses without a dotted domain suffix are treated as valid.Triage rationale
The bug is isolated to a single validation helper and an existing test already captures the expected behavior.
Changed files
src/business.jsValidation
node -e "require('./src/business'); require('./src/app'); console.log('modules load')"