[Fixes #48] Reinstate png, jpg support. Removes imagen-legacy dependency.#83
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR migrates image mosaic generation away from the legacy Imagen codec APIs by switching TIFF/image reading to the newer ImageRead operation and ParameterBlockImageN, and removes the legacy codec dependency from the build.
Changes:
- Replace legacy
FileSeekableStream+ParameterBlockusage withParameterBlockImageNand theImageReadoperation. - Add debug logging guard and minor readability tweaks in width calculation.
- Remove
imagen-legacy-codec-corefrompom.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/mapfish/print/output/FileCachingJaiMosaicOutputFactory.java | Updates image read/translate/mosaic construction to use ParameterBlockImageN + ImageRead instead of legacy codec classes. |
| pom.xml | Drops the legacy codec dependency now that it’s no longer used by the mosaic pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+113
to
+115
| ParameterBlockImageN pb = new ParameterBlockImageN("ImageRead"); | ||
| pb.setParameter("Input", imageinfo.imageFile); | ||
| RenderedOp source = ImageN.create("ImageRead", pb); |
Comment on lines
+118
to
+120
| if(LOGGER.isDebugEnabled()) { | ||
| LOGGER.debug("Adding page image " + i + " bounds: [" + 0 + "," + height + " " + source.getWidth() + "," + (height + source.getHeight()) + "]"); | ||
| } |
Comment on lines
+137
to
+142
| ParameterBlockImageN pbTranslate = new ParameterBlockImageN("translate"); | ||
| pbTranslate.addSource(source); | ||
| pbTranslate.setParameter("xTrans", 0f); | ||
| pbTranslate.setParameter("yTrans", height); | ||
| return ImageN.create("translate", pbTranslate); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.